Skip to content

Conversation

@PProfizi
Copy link
Contributor

Add a 'check_validity' argument to the dpf_mesh_to_vtk function.

… 'check_validity' argument to the dpf_mesh_to_vtk function.

Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 81.94444% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (5efdcaf) to head (5aa311e).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1836      +/-   ##
==========================================
- Coverage   83.76%   83.75%   -0.02%     
==========================================
  Files          90       90              
  Lines       10318    10388      +70     
==========================================
+ Hits         8643     8700      +57     
- Misses       1675     1688      +13     

@PProfizi PProfizi marked this pull request as ready for review October 29, 2024 13:46
@PProfizi PProfizi requested a review from a team as a code owner November 22, 2024 09:20
@PProfizi PProfizi removed the request for review from a team May 5, 2025 08:13
@PProfizi PProfizi self-assigned this May 5, 2025
@PProfizi PProfizi added the enhancement New feature or request label May 5, 2025
@PProfizi PProfizi merged commit c4298ea into master May 5, 2025
80 of 81 checks passed
@PProfizi PProfizi deleted the feat/add_vtk_grid_check branch May 5, 2025 12:54
@user27182
Copy link

Hi, I am looking to implement something similar to the vtk_mesh_is_valid function upstream (i.e. friendly version of vtkCellValidator) to incorporate it directly as part of PyVista.

@PProfizi do you mind if I use this source code? Both projects use MIT license... not sure if there are any disclaimers or notices I need to include?

@PProfizi
Copy link
Contributor Author

PProfizi commented Dec 1, 2025

Hello @user27182, as long as the licensing terms at the beginning of the file containing the code of interest are respected I see no issue.
That would actually allow me to use this validation function directly from PyVista instead of maintaining it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants